curioustorvald/tsvm
1
0
Fork 0
mirror of https://github.com/curioustorvald/tsvm.git synced 2026-06-15 17:04:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

taut fix ghost vox orphanage

Browse Source
This commit is contained in:
minjaesong
2026-06-15 02:07:09 +09:00
parent fc17892a23
commit f4c6c945b1
3 changed files with 38 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tsvm_core/src/net/torvald/tsvm/peripheral/AudioAdapter.kt
View File

@@ -3758,6 +3758,22 @@ class AudioAdapter(val vm: VM) : PeriBase(VM.PERITYPE_SOUND) {
if (bg.isLayerChild) {
val parent = ts.voices.getOrNull(bg.sourceChannel)
if (parent == null || !parent.active) {
// Parent note ended: detach so this layer finishes its own release as a
// plain ghost. But if the parent was RELEASED (key-off / note-fade) and its
// own fadeout deactivated it in the SAME tick the release fired — a fast
// fadeout, e.g. fo≈1067 (a 1-tick cut) — the parent-sync below never ran
// while it was active, so the release was never carried across and a still
// looping/sustaining child would ring on until the next note displaces it.
// Inherit the parent's final release here before detaching (parent.keyOff /
// noteFading survive deactivation; both are reset on retrigger, so a true
// value means THIS note was released, not a stale flag). A parent that ended
// without release (natural sample/env end) leaves the child to finish on its
// own, unchanged. Symptom: long tails on multi-layer SF2 presets with a short
// release, e.g. Timbres of Heaven's sustained guitars/organs.
if (parent != null && !bg.keyOff && !bg.noteFading) {
if (parent.keyOff) { bg.keyOff = true; applyKeyLift(bg, instruments[bg.instrumentId]) }
else if (parent.noteFading) bg.noteFading = true
}
bg.isLayerChild = false
} else {
bg.noteVal = (parent.noteVal + bg.layerRelDetune).coerceIn(0x20, 0xFFFF)